https://bugzilla.redhat.com/show_bug.cgi?id=1756901 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Blocks|177841 (FE-NEEDSPONSOR) | Flags| |fedora-review+ --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons CC0 Public License (v1.0)", "Unknown or generated", "*No copyright* Aladdin Free Public License", "Academic Free License (v1.1)", "Academic Free License (v1.2)", "Academic Free License (v2.0)", "Academic Free License (v2.1)", "Academic Free License (v3.0)", "GNU Affero General Public License (v1)", "GNU Affero General Public License (v3)", "BSD (unspecified)", "Adobe Postscript AFM License", "Adobe Systems Incorporated Source Code License Agreement", "Adobe Glyph List License", "Apache License (v1.1)", "Artistic License", "Artistic License (v2.0)", "BSD 2-clause "Simplified" License", "*No copyright* BSD 3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised" License", "BSD 4-clause "Original" or "Old" License", "*No copyright* BSD (unspecified) GNU General Public License", "*No copyright* Boost Software License (v1.0) Boost Software License 1.0", "*No copyright* Beerware License", "Creative Commons Attribution Public License (v1.0)", "Creative Commons Attribution Public License (v2.0)", "Creative Commons Attribution Public License (v2.5)", "Creative Commons Attribution Public License (v3.0)", "Creative Commons Attribution Public License (v4.0)", "Creative Commons Attribution-NonCommercial Public License (v1.0)", "Creative Commons Attribution-NonCommercial Public License (v2.0)", "Creative Commons Attribution-NonCommercial Public License (v2.5)", "Creative Commons Attribution-NonCommercial Public License (v3.0)", "Creative Commons Attribution-NonCommercial Public License (v4.0)", "Creative Commons Attribution-NonCommercial-NoDerivatives Public License (v1.0)", "Creative Commons Attribution-NonCommercial- NoDerivatives Public License (v2.0)", "Creative Commons Attribution- NonCommercial-NoDerivatives Public License (v2.5)", "Creative Commons Attribution-NonCommercial-NoDerivatives Public License (v3.0)", "Creative Commons Attribution-NonCommercial-NoDerivatives Public License (v4.0)", "Creative Commons Attribution-NonCommercial- ShareAlike Public License (v1.0)", "Creative Commons Attribution- NonCommercial-ShareAlike Public License (v2.0)", "Creative Commons Attribution-NonCommercial-ShareAlike Public License (v2.5)", "Creative Commons Attribution-NonCommercial-ShareAlike Public License (v3.0)", "Creative Commons Attribution-NonCommercial-ShareAlike Public License (v4.0)", "Creative Commons Attribution-NoDerivatives Public License (v1.0)", "Creative Commons Attribution-NoDerivatives Public License (v2.0)", "Creative Commons Attribution-NoDerivatives Public License (v2.5)", "Creative Commons Attribution-NoDerivatives Public License (v3.0)", "Creative Commons Attribution-NoDerivatives Public License (v4.0)", "Creative Commons Attribution-ShareAlike Public License (v1.0)", "Creative Commons Attribution-ShareAlike Public License (v2.0)", "Creative Commons Attribution-ShareAlike Public License (v2.5)", "Creative Commons Attribution-ShareAlike Public License (v3.0)", "Creative Commons Attribution-ShareAlike Public License (v4.0)", "Common Development and Distribution License (v1.0)", "Common Development and Distribution License (v1.1)", "CeCILL License (v1)", "CeCILL License 2.1", "CeCILL-B License", "CeCILL-C License", "GNU General Public License", "Cube License", "DSDP License", "Eclipse Public License (v1.0)", "Eurosym License", "*No copyright* FSF All Permissive License", "FSF Unlimited License", "FSF Unlimited License (with Retention)", "FreeType License", "GNU Free Documentation License (v1.1)", "GNU Free Documentation License (v1.2)", "GNU Free Documentation License (v1.3)", "NTP License", "*No copyright* NTP License (legal disclaimer)", "ICU License", "ISC License", "*No copyright* enna License", "Expat License JSON License JSON", "Eclipse Public License (v1.0) Common Development and Distribution License CeCILL-C License", "Eclipse Public License (v1.0) CeCILL License (v2.1)", "CMU License", "Enlightenment License (e16)", "enna License", "*No copyright* feh License", "Expat License", "*No copyright* Expat License", "*No copyright* Mozilla Public License (v1.1)", "Mozilla Public License (v2.0)", "Microsoft Public License", "Microsoft Reciprocal License", "*No copyright* Mozilla Public License", "Mozilla Public License (v1.1)", "Academic Free License", "SIL Open Font License (v1.0)", "SIL Open Font License (v1.1)", "Mozilla Public License (v2.0) GNU Affero General Public License (v3.0 or later)", "OpenSSL License BSD 4-clause "Original" or "Old" License", "PostgreSQL License", "Python Software Foundation License version 2", "Q Public License (v1.0)", "RealNetworks Public Source License (v1.0)", "Public domain", "SGI Free Software License B (v1.0)", "SGI Free Software License B (v1.1)", "SGI Free Software License B (v2.0)", "CMU License (retain warranty disclaimer)", "Unicode Terms of Use", "do What The Fuck you want to Public License (v2)", "*No copyright* zlib/libpng license", "curl License", "*No copyright* Academic Free License (v1.1)", "*No copyright* GNU General Public License", "GPL (v2 or later)", "zlib/libpng License with Acknowledgement". 199 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-spdx/review-python- spdx/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-spdx-2.5.0-1.fc32.noarch.rpm python-spdx-2.5.0-1.fc32.src.rpm python3-spdx.noarch: E: incorrect-fsf-address /usr/lib/python3.8/site-packages/spdx/data/deprecated_WXwindows.txt 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
