[Bug 1758293] Review Request: jboss-logging-tools - JBoss Logging I18n Annotation Processor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1758293



--- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Dinesh Prasanth from comment #3)
> Thanks, Fabio for initial set of feedbacks. And I apologize for the wrong
> description! This is my first package in the review process :)
> 
> For your feedback:
> 
> I have fixed #1 and #3

You'll also need to create a changelog entry for the -9 release, though.

> For #2, instead of %{name}-%{namedversion}, I had to keep %{namedversion}
> since the releases in GH are named that way [1]

Ah, sorry, that's due to some copypasta on my side. It should be this:

Source0:        %{url}/archive/%{namedversion}/%{name}-%{namedversion}.tar.gz

> For #4, the error is due to missing dep (jdeparser) which was retired too.
> It seems like it needs to revived too. I went ahead and built it on my COPR
> and seems like jboss-logging-tools can now successfully build [2]

That's good news. It's always nice if you can actually run the test suites in
your packages :)

> Question: Should I open a new bz to revive jdeparser too?
> 
> I went ahead and filed a review ticket for jdeparser: bz#1758686

Great, I'll look at that one as well.

> [1] https://github.com/jboss-logging/jboss-logging-tools/releases
> [2]
> https://copr.fedorainfracloud.org/coprs/dmoluguw/jboss-logging-tools/build/
> 1046077/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux