[Bug 1758293] Review Request: jboss-logging-tools- re-review of retired package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1758293



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I would also like to make some improvements to the package before we re-import
it into fedora, instead of just pushing the f30 .spec file again.

1) You need to make sure NEVR of the new package sorts higher than what's last
available in fedora right now. I think bumping the Release to "9" should be
enough in this case.

2) For the Source0 tag, we could use:

Source0:        %{url}/archive/%{name}-%{namedversion}.tar.gz

This produces a file that also contains the name, not only the version.

3) Have you tried regenerating the BuildRequires with xmvn-builddep? Not all of
them might be necessary anymore.

4) Why are the test failures ignored? Is the error still occurring, or is it
something we can fix?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux