https://bugzilla.redhat.com/show_bug.cgi?id=1326504 --- Comment #26 from Jun Aruga <jaruga@xxxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/junaruga/htslib-pkg/hotfix/review/htslib.spec SRPM URL: https://github.com/junaruga/htslib-pkg/blob/hotfix/review/htslib-1.9-1.fc32.src.rpm?raw=true I updated the spec and SRPM files again. > I renamed libhts-so.1.9 to libhts-1.9.so asking the question to the upstream here https://github.com/samtools/htslib/issues/932#issuecomment-536212327 to align glic(libc)'s style. I changed again. Now using upstream libraries directly without renaming. See https://github.com/samtools/htslib/issues/932#issuecomment-537694737 zlib on Fedora is same pattern with htslib. I think htslib is correct. We can update the Fedora guideine line later. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning * Koji scratch build: ok https://koji.fedoraproject.org/koji/taskinfo?taskID=38010659 * Test to install RPMs: ok * rpmlint: ok, as I mentioned we can fix below warning later, as this ticket blocks other tickets right now. ``` htslib.x86_64: W: shared-lib-calls-exit /usr/lib64/libhts.so.1.9 exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. ``` As I assume that you are busy now, I will ask people to review on devel@ mailing list. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
