https://bugzilla.redhat.com/show_bug.cgi?id=1751138 --- Comment #4 from Petr Menšík <pemensik@xxxxxxxxxx> --- (In reply to Raphael Groner from comment #1) > Some general hints: > > Drop this line: > - %global commit v%{version} > > Simplify those lines: > - URL: https://github.com/DNS-OARC/flamethrower > - Source0: > https://github.com/DNS-OARC/%{name}/archive/%{commit}/%{name}-%{commit}.tar. > gz > + URL: https://github.com/DNS-OARC/%{name} > + Source0: %{url}/archive/v%{version}/%{name}-v%{version}.tar.gz This is good, I think it should be used. > > - Patch1: flamethrower-0.10-libuv.patch > + Patch1: %{name}-0.10-libuv.patch No, I do no think %{name} is useful when listing files. It should be named as it is. Those files are named the same on filesystem. Changing spec file name does not rename them. It is more handy to just select and paste on full form. > > - make %{?_smp_mflags} > + %make_build > > Why does %make_install not work though cmake is used to generate a useful > Makefile? No rules where it should be installed was given I suppose. It just lacks install target. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
