https://bugzilla.redhat.com/show_bug.cgi?id=1728381 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(crobinso@redhat.c | |om) | --- Comment #9 from Cole Robinson <crobinso@xxxxxxxxxx> --- (In reply to Alex Williamson from comment #8) > Thanks for the review Cole, sorry for the delay in getting back to this. > > (In reply to Cole Robinson from comment #7) > > FWIW this packages is quite similar to driverctl which is already in Fedora. > > driverctl review bug: https://bugzilla.redhat.com/show_bug.cgi?id=1372670 > > > > Trimmed output from fedora-review: > > > > > > - Sources used to build the package match the upstream source, as provided > > in the spec URL. > > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > > > The source URL looks acceptable per the docs, but looks like the archive in > > the SRPM is not the same content as github generates. Please fix that > > Fixed, I don't know how to control the directory structure github uses in > the tarball, so I dropped the sha1 from the local build to match github. > I don't think there's any way to control the github directory structure. There is a way to get a .tar.gz per commit, using some github URL magic. https://github.com/mdevctl/mdevctl/archive/e2bda0996bd37d12da6292d8dc6d4a938f657e86/mdevctl-e2bda0996bd37d12da6292d8dc6d4a938f657e86.tar.gz > > > - Changelog in prescribed format. > > > > Changelog lines should be individually prefixed with '-' and contain a > > version string > > at the end. > > > > Your changelog there looks more like it should be a NEWS.md file which you > > can ship > > as %doc. Using that is better for upstream too IMO because other distros > > won't want a .spec file to be the canonical release notes. > > > > For Fedora spec the changelog should be the package version history so all > > of those > > entries should be trimmed except the most recent one basically. > > Fixed. What's present now is still entirely auto-generated from the git > log, as I think that is our canonical release notes. However, the > formatting now matches the Fedora requirements and we're rolling together > all the commit subjects between tags. I think this will allow me to merge > the upstream auto-generated spec file with the Fedora maintained one fairly > automatically, assuming it's good practice to maintain the logs for Fedora > specific rebuilds. Dealing with changelogs across upstream hosted spec and downstream is a pain. Most projects I work on just don't include a %changelog upstream. But whatever works for you as long as the format is appropriate for Fedora. The new version looks good, but the archive still doesn't match the Source content. Please update the src.rpm with the archive from the Source link: https://github.com/mdevctl/mdevctl/archive/0.49/mdevctl-0.49.tar.gz After that I'll approve the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
