https://bugzilla.redhat.com/show_bug.cgi?id=1757379 --- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Most test managers (nose/pytest) allow you to disable individual tests. So the failing tests can be temporarily disabled. These should be reported upstream, and a comment added in the spec to explain why they are disabled and a link to the upstream issue. It also depends on why the tests fail, though. For imaging libraries, tests often try to fetch data from the internet and so fail (since koji does not have internet access). In this case, one can run the build in mock enabling network to confirm that the tests pass, and then disable them in the committed spec. You can use macros for conditional builds to make this easier: https://rpm.org/user_doc/conditional_builds.html We've made this note in the spec template here: https://pagure.io/neuro-sig/NeuroFedora/blob/master/f/spec-templates/python.spec#_2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
