[Bug 1757166] Review Request: gedit-plugin-editorconfig - EditorConfig plugin for Gedit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1757166



--- Comment #3 from "FeRD" (Frank Dana) <ferdnyc@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #2)
>  - Use:
> 
> Source0:       
> https://github.com/editorconfig/editorconfig-gedit/archive/v%{version}/
> editorconfig-gedit-%{version}.tar.gz
> 

Done.

>  - Build fails:
> 
> + %py_byte_compile /usr/bin/python3
> /builddir/build/BUILDROOT/gedit-plugin-editorconfig-0.5.3-1.fc32.x86_64/usr/
> lib64/gedit/plugins/editorconfig_plugin
> /var/tmp/rpm-tmp.2QX1tx: line 43: fg: no job control
> 
>  I believe you need to BR python3-devel to use this macro:
> 
> BuildRequires:  python%{python3_pkgversion}-devel

Whoops, duh. Fixed.

>  - Own this dir by removing the *:
> 
> %{_libdir}/gedit/plugins/editorconfig_plugin/__pycache__/

Ah, it seems I misread
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_byte_compiling
... fixed.


Specfile and .srpm both updated at links provided in original request. All
items addressed. (And tested in mock this time, so I know it actually builds.
O:) )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux