https://bugzilla.redhat.com/show_bug.cgi?id=1754964 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Notes through initial pass of review: > %global _pkgdocdir %{_docdir}/%{name}-%{version} Why are we overriding pkgdocdir this way? > Suggests: %{name} = %{version}-%{release} This should be using "Enhances" instead of "Suggests", as this is a reverse relationship. > ln -s brz.1 %{buildroot}%{_mandir}/man1/bzr.1 This doesn't do *exactly* the thing you expect. Do something like this: > # Link bzr(1) to brz(1) > echo ".so man1/brz.1" > %{buildroot}%{_mandir}/man1/bzr.1 This ensures man-db does the correct thing for references. > %doc %{_pkgdocdir}/COPYING.txt Please relocate the license properly and install it via "%license" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
