https://bugzilla.redhat.com/show_bug.cgi?id=1739816 --- Comment #8 from Ege Güneş <egegunes@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #7) > (In reply to Ege Güneş from comment #6) > > (In reply to Robert-André Mauchin from comment #5) > > > - That's not needed, the file should be in licensedir > > > > > > %{_docdir}/redminecli/LICENSE > > > > > > > The setup.py script tries to install license to `sys.prefix` (`/usr`) if > > include it in the dist. I couldn't see any macro that points to default > > licensedir. Can you point me the right direction? > > mv it to %{_defaultlicensedir} if needed or exclide it with %exclude > I excluded the license from dist. > > > > > - You haven't added the tests? > > > > Tests confused me because Python Packaging Docs[1] explicitly says "Python > > modules must not download any dependencies during the build process.". But I > > need to download the packages' dependencies to test it? Am I missing > > something? > > > > [1] > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > > #_reviewer_checklist > > If there is some needed deps, add them as BR. But I ran the tests with no > issues without any added BR: > Tests require python3-pytest, python3-click and python3-requests to run. I built the rpm with tests successfully on my machine, because I had these packages already installed on my system. Maybe you had those too? Anyway I added them as BR. Spec URL: https://copr-be.cloud.fedoraproject.org/results/egegunes/redminecli/fedora-30-x86_64/01040882-redminecli/redminecli.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/egegunes/redminecli/fedora-30-x86_64/01040882-redminecli/redminecli-1.1.8-1.fc30.src.rpm Latest Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=37882269 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
