https://bugzilla.redhat.com/show_bug.cgi?id=1749383 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #25 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Javi Roman from comment #20) > Spec URL: > https://src.fedoraproject.org/fork/jromanes/rpms/mesos/raw/f30/f/mesos.spec > SRPM URL: > https://github.com/javiroman/mesos-rpm/raw/master/mesos-1.8.1-2.fc30.src.rpm > > New candidate: > > - %pom_remove_plugin :maven-gpg-plugin did the trick (many thanks @Fabio) > - maven-site-plugin removed without problems, this was my fault, it's not a > dependency at all. All good on my side. > Right now I'm checking with f31 too, however it looks zookeeper package is > no ready yet (and it's a dependency): > https://apps.fedoraproject.org/packages/zookeeper/ I can help you with zookeeper, it seems the last update was applied 2 years ago, we can probably push some changes. (In reply to Tom "spot" Callaway from comment #24) > The script to generate the clean tarball is fine, but this removal is not > related to patents, so the comment in the spec (as well as the naming schema > for the clean tarball) is incorrect. I would suggest: > > Source0: %{name}-%{version}-clean.tar.gz > # The upstream Apache Mesos source release > # > https://dist.apache.org/repos/dist/release/mesos/<version>/mesos-<version>. > tar.gz > # contains non-free code that we cannot ship. Therefore we use > # this script to remove the non-free code before shipping it. @Javi If you fix the comment with the above I would say the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
