[Bug 1753837] Review Request: primecount - Fast prime counting function implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1753837



--- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Michal Schorm from comment #5)
> Let me explain:
> The code you use now:
>  | %build
>  | %ifarch %{ix86} x86_64
>  | export CFLAGS="%{optflags} -DLIBDIVIDE_SSE2"
>  | export CXXFLAGS="$CFLAGS"
>  | %endif
> 
> If the IF-CLAUSE fail (other than x86 arch), it will result in a situation,
> when you don't have set any flags.

No, it won't.  The %cmake macro does the equivalent of %set_build_flags, so
this simply results in adding one flag on x86 arches, and using the defaults on
all other arches.  The libdivide review has completed, so it is now possible to
do a scratch build of primecount.  Take a look:

https://koji.fedoraproject.org/koji/taskinfo?taskID=37829514

The proper flags are used on all architectures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux