https://bugzilla.redhat.com/show_bug.cgi?id=1751660 --- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - %global with_tests 0 > > Use bcond_with/bcond_without > > Also why tests are disabled? If there is no tests drop the entire %check > section. Because koji doesn't have connectivity to the internet, it is useful for local use though. > - Use: > > Source0: > https://github.com/ur1katz/casttube/archive/%{version}/%{pypi_name}- > %{version}.tar.gz Updated. > - It is verbotten to glob the entire Python sitelib, be more precise > instead: What does verbotten mean? I figure it means forbidden. If so updated. > %{python3_sitelib}/casttube > %{python3_sitelib}/casttube-%{version}-py*.egg-info > > > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_files_to_include > > - Summary is coo long and should not repeat the app name: > > Summary: Python library to interact with the Youtube Chromecast api > > - Description is too long, split it to stbay under 80 characters per line: > > python3-casttube.noarch: E: description-line-too-long C Casttube is a python > library which a way to interact with the Youtube Chromecast api. Updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
