https://bugzilla.redhat.com/show_bug.cgi?id=1752139 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #8 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - %makeinstall is forbidden, use %make_install [!]: Package use %makeinstall only when make install DESTDIR=... doesn't work. Note: %makeinstall used in %install section - Each patch must be justified either with a comment or a link to a bug report/merge request: [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. - Group: is not used in Fedora - Source1: logo-mode.tar.gz Where does this come from? How is it generated? You must document it in order to be reproducible. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments - Add Requires: hicolor-icon-theme to own the icons directories. - Add Requires: emacs-filesystem to own the emacs directories [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/emacs, /usr/share/emacs/site-lisp, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor - Add BuildRequires: emacs and use %{_emacs_sitelispdir} instead of %{_datadir}/emacs/site-lisp/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
