https://bugzilla.redhat.com/show_bug.cgi?id=1752233 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use a better name for your archive: Source: https://github.com/adsr/mle/archive/v%{version}/%{name}-%{version}.tar.gz - %make_install already specify DESTDIR, not need to repeat it: %make_install prefix=%{_prefix} - use install -p to keep timestamps: install -D -p -v -m 644 mle.1 ${RPM_BUILD_ROOT}%{_mandir}/man1/mle.1 Consider patching the makefile to use $(INSTALL) instead of install to keep timestamps. - You must install the licence files with %license in %files, and you should install the README with %doc: %files %license LICENSE %doc README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
