https://bugzilla.redhat.com/show_bug.cgi?id=1752158 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use a better name for your archive: Source: https://github.com/nsf/termbox/archive/v%{version}/%{name}-%{version}.tar.gz - devel must require the main package: Requires: %{name}%{?_isa} = %{version}-%{release} See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package - static library are generally not packaged in Fedora, you should instead drop the extra file in %install: rm -rf $RPM_BUILD_ROOT%{_libdir}/*.{a,la} See https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries - unversionned so files go in the devel subpackage %files %{_libdir}/libtermbox.so.1 %{_libdir}/libtermbox.so.1.* %files devel %{_libdir}/libtermbox.so %{_includedir}/termbox.h See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - You should add BuildRequires: waf and run waf directly instead of using the provided copy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
