Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-printer https://bugzilla.redhat.com/show_bug.cgi?id=226466 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-04 01:37 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but Not for RPM. system-config-printer.i386: W: non-conffile-in-etc /etc/xdg/autostart/redhat-print-applet.desktop system-config-printer.i386: E: no-binary These messages can be ignored for this package. system-config-printer.i386: W: no-version-in-last-changelog system-config-printer-libs.i386: W: no-version-in-last-changelog ==> These can be corrected at time of cvs import. + source files match upstream. 20b18338b46531b1b28602deb44aa07d pycups-1.9.27.tar.bz2 a332f8598c0a4afcc72123856733e273 system-config-printer-0.7.74.4.tar.bz2 b265be98565333de000309e14deea408 system-config-printer.console f5be82be51135cf46de5955695f67c0d system-config-printer.pam + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists but --libs exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop files are handled correctly in Makefile only so no need to have dekstop-file-install called in SPEC. + package system-config-printer-0.7.74.4-1.0.0.1.fc8 -> Provides: config(system-config-printer) = 0.7.74.4-1.0.0.1.fc8 desktop-printing = 0.20-7.fc7 system-config-printer-gui = 0.6.152 Requires: /bin/sh /usr/bin/env /usr/bin/python config(system-config-printer) = 0.7.74.4-1.0.0.1.fc8 dbus-x11 desktop-file-utils >= 0.2.92 pirut pygobject2 pygtk2 >= 2.4.0 pygtk2-libglade system-config-printer-libs = 0.7.74.4-1.0.0.1.fc8 usermode >= 1.37 + package system-config-printer-libs-0.7.74.4-1.0.0.1.fc8 -> Provides: config(system-config-printer-libs) = 0.7.74.4-1.0.0.1.fc8 cups.so pycups = 1.9.27 Requires: /usr/bin/env config(system-config-printer-libs) = 0.7.74.4-1.0.0.1.fc8 foomatic libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcups.so.2 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpython2.5.so.1.0 python python(abi) = 2.5 rtld(GNU_HASH) + GUI app. APPROVED. Remember-> rpmlint complained some more extra messages now system-config-printer.i386: W: no-version-in-last-changelog system-config-printer-libs.i386: W: no-version-in-last-changelog ==> These can be corrected at time of cvs import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review