[Bug 1747552] Review Request: libdfp - Decimal Floating Point library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1747552

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
- Use %global, not %define:

%global cpu_variants power6

 - Missing isa:

Requires:       %{name}%{?_isa} = %{version}-%{release}

 - It seems it should be:

%prep
%autosetup -p1 -n %{name}-%{version}

 - make %{?_smp_mflags} → %make_build

 - make install install_root=%{buildroot} → %make_install

 - Not needed: %defattr(-,root,root,-)

 - Use %ldconfig_scriptlets instead of:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

 - In order to avoid unintentional soname bumps, we forbid the globbing of the
major soname version, be more specific instead:

%{_libdir}/*.so.*

 - # Install COPYING.txt to _docdir.
Patch3: libdfp-license.patch

Why? COPYING.txt should not go to _docdir but be installed to licensedir with:

%license COPYING.txt

The file will be copied to the right location by rpm.


> Will epel8 use a newer gcc-8.3.* as soon as such a newer version is available in RHEL 8?

I have no idea how RHEL work, but EPEL8 will use it soon after it is available
in RHEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux