https://bugzilla.redhat.com/show_bug.cgi?id=1753769 --- Comment #2 from Petr Menšík <pemensik@xxxxxxxxxx> --- Sweet little thing. Quite simple and nice. However one issue in compilation was found. Since it does not use configure, no %configure is used. That would be fine, it is not required. What is required however, is usage of CFLAGS and LDFLAGS defined for packaging. What should be used can be checked by command: # rpm -E '%configure' | grep FLAGS 1) CFLAGS and LDFLAGS have to be configured before make. Please add %set_build_flags before %make_build 2) Current Makefile redefines CFLAGS, so it cannot reuse rpm cflags even if they were defined. Makefile should be modified to use CFLAGS configured before. In my test, this worked fine: CFLAGS := $(CFLAGS) -W -Wall -pedantic -g `curl-config --cflags` If no CFLAGS is defined, it would still work as before. When it is, it is used. Not sure if this would be supported by different make flavour, but fine for Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
