https://bugzilla.redhat.com/show_bug.cgi?id=1753837 Michal Schorm <mschorm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Michal Schorm <mschorm@xxxxxxxxxx> --- I went through the results and here are my observations: 1) The require on line 20 isn't IMHO needed at all. If the binary links with the library, the RPM build will automatically generate dependency to that library. So if you remove the line, it will look like this: |# dnf install ./primecount-5.1-1.fc32.x86_64.rpm | Problem: conflicting requests | - nothing provides libprimecount.so.5()(64bit) needed by primecount-5.1-1.fc32.x86_64 2) It's better to use the %{set_build_flags}, instead of just %{optflags}. As you can see e.g. here: https://src.fedoraproject.org/rpms/mariadb-connector-c/blob/master/f/mariadb-connector-c.spec#_78 3) Personally, I prefer to write short patch justification as a comment in the SPECfile and a verbose justification at the beginning of the patch (file). 4) You can also fix some of the RPMLint errors by whitelisting them with a justification. Take a glimpse at my package, how it looks: https://src.fedoraproject.org/rpms/mariadb-connector-c/blob/master/f/mariadb-connector-c.rpmlintrc 5) I haven't tested it builds and works on all supported architectures, since the requirement is not yet in Fedora. I marked this BZ as "Depends On: 1753084" ----- Other than (1), (2) and (5), I don't have any objections and I feel the package is ready for Fedora, after we solve those three findings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
