[Bug 1747853] Review Request: golang-github-captncraig-caddy-realip - Real-IP middleware for caddy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1747853



--- Comment #3 from Carl George <carl@george.computer> ---
> - Fix the Release info in your %changelog entry:

Is that still a requirement?  I noticed the new go macros do that automatically
by overriding %dist.  Compare the release to the filename of the source RPM.

Release:        0.1%{?dist}

golang-github-captncraig-caddy-realip-0-0.1.20190828git6df827e.fc32.src.rpm

Including the build date in the release field results in it being in the
release twice, so I removed it there.  At that point including that in the
changelog seems problematic because it would be easy to get out of sync with
the actual build date.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux