https://bugzilla.redhat.com/show_bug.cgi?id=1750777 Adam Williamson <awilliam@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@xxxxxxxxxx --- Comment #1 from Adam Williamson <awilliam@xxxxxxxxxx> --- So, the biggest thing I note is one you're on upstream already but don't mention anywhere in the spec: https://github.com/nikipore/stompest/pull/54 that is not merged, and without it, a large chunk of this library is problematic on Python 3.7+ (due to being called 'async', which is a reserved keyword from Python 3.7 on)...which is what we have in all supported Fedoras. What's your take on this? Should we backport that PR? Do something else? rpmlint on the SRPM: 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 🎉🎉🎉 Package builds successfully on F31 and passes tests, with some warnings: =============================== warnings summary =============================== stompest/protocol/failover.py:40 /builddir/build/BUILD/stompest-2.3.0/stompest/protocol/failover.py:40: DeprecationWarning: invalid escape sequence \. _REGEX_LOCALHOST_IPV4 = re.compile('^127\.\d+\.\d+\.\d+$') stompest/protocol/failover.py:143 /builddir/build/BUILD/stompest-2.3.0/stompest/protocol/failover.py:143: DeprecationWarning: invalid escape sequence \d _REGEX_URI = re.compile('^(?P<protocol>(tcp|ssl))://(?P<host>[^:]+):(?P<port>\d+)$') stompest/protocol/failover.py:144 /builddir/build/BUILD/stompest-2.3.0/stompest/protocol/failover.py:144: DeprecationWarning: invalid escape sequence \( _REGEX_BRACKETS = re.compile('^\((?P<uri>.+)\)$') stompest/tests/parser_test.py:294 /builddir/build/BUILD/stompest-2.3.0/stompest/tests/parser_test.py:294: DeprecationWarning: invalid escape sequence \c for badCharacter in (b'\r', b'\n', b'\c', b'\\', b':', b'\\h'): -- Docs: https://docs.pytest.org/en/latest/warnings.html ==================== 72 passed, 4 warnings in 2.15 seconds ===================== rpmlint on the binary package: 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 🎉🎉🎉 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
