[Bug 1750045] Review Request: abhaya-libre-fonts - Libre version of FM Abhaya font

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1750045

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Not a valid license shourthand, it should be "OFL":

License:        SIL Open Font License

 - Use a better name for your archive:

Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz

 - What is this:

%undefine _disable_source_fetch

 - Use %autosetup

%setup -q -c

 then:

install -m 0644 -p fonts/ttf/AbhayaLibre-Bold.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-ExtraBold.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-Medium.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-Regular.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-SemiBold.ttf %{buildroot}%{_fontdir}

 - Don't:

install -m 0755 -d %{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/CONTRIBUTORS.md
%{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/README.md
%{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/OFL.txt
%{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/FONTLOG.md
%{buildroot}/usr/share/doc/%{fontname}

 The license file must be installed with %license in %files:

%license OFL.txt

 The docs should be installed with %doc in %files:

%doc CONTRIBUTORS.md README.md FONTLOG.md

 - Release should start at 1 in Fedora not 0:

Release:        0%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux