https://bugzilla.redhat.com/show_bug.cgi?id=1749383 --- Comment #11 from Simone Caronni <negativo17@xxxxxxxxx> --- A few more things after running rpmlint: $ rpmlint *rpm mesos.src: W: strange-permission mesos-init-wrapper 775 mesos.x86_64: W: incoherent-version-in-changelog 1.8.1 ['1.8.1-1.fc30', '1.8.1-1'] mesos.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libmesos-1.8.1.so SSL_CTX_set_cipher_list mesos.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/libmesos-1.8.1.so mesos.x86_64: E: wrong-script-interpreter /etc/mesos/mesos-deploy-env.sh.template /usr/bin/env bash mesos.x86_64: E: non-executable-script /etc/mesos/mesos-deploy-env.sh.template 644 /usr/bin/env bash mesos.x86_64: W: tmpfiles-conf-in-etc /etc/tmpfiles.d/mesos.conf mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.deps mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.deps mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.deps/.dirstamp mesos.x86_64: E: zero-length /usr/share/mesos/examples/.deps/.dirstamp mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.dirstamp mesos.x86_64: E: zero-length /usr/share/mesos/examples/.dirstamp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/balloon_executor.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/balloon_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/disk_full_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/docker_no_executor_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/dynamic_reservation_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/example_module_impl.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/flags.hpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/inverse_offer_framework.cpp mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/test-exception-framework.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/test-exception-framework.in 644 /usr/bin/env bash mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/test-executor.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/test-executor.in 644 /usr/bin/env bash mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/test-framework.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/test-framework.in 644 /usr/bin/env bash mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/test-log.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/test-log.in 644 /usr/bin/env bash mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/test-multiple-executors-framework.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/test-multiple-executors-framework.in 644 /usr/bin/env bash mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/v1-test-framework.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/v1-test-framework.in 644 /usr/bin/env bash mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/load_generator_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/long_lived_executor.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/long_lived_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/no_executor_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/operation_feedback_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/persistent_volume_framework.cpp mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/python/test-executor.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/python/test-executor.in 644 /usr/bin/env bash mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/python/test-framework.in /usr/bin/env bash mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/python/test-framework.in 644 /usr/bin/env bash mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_allocator_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_anonymous_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_anonymous_module.hpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_authentication_modules.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_authorizer_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_container_logger_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_csi_plugin.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_csi_user_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_executor.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_hook_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_http_authenticator_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_http_executor.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_http_framework.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_isolator_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_master_contender_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_master_detector_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_module.hpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_qos_controller_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/test_resource_estimator_module.cpp mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/utils.hpp mesos.x86_64: W: non-standard-uid /var/lib/mesos mesos mesos.x86_64: W: non-standard-gid /var/lib/mesos mesos mesos.x86_64: W: non-standard-uid /var/log/mesos mesos mesos.x86_64: W: non-standard-gid /var/log/mesos mesos mesos.x86_64: W: log-files-without-logrotate ['/var/log/mesos'] mesos.x86_64: W: no-manual-page-for-binary mesos mesos.x86_64: W: no-manual-page-for-binary mesos-cat mesos.x86_64: W: no-manual-page-for-binary mesos-execute mesos.x86_64: W: no-manual-page-for-binary mesos-init-wrapper mesos.x86_64: W: no-manual-page-for-binary mesos-local mesos.x86_64: W: no-manual-page-for-binary mesos-log mesos.x86_64: W: no-manual-page-for-binary mesos-ps mesos.x86_64: W: no-manual-page-for-binary mesos-resolve mesos.x86_64: W: no-manual-page-for-binary mesos-scp mesos.x86_64: W: no-manual-page-for-binary mesos-tail mesos.x86_64: W: no-manual-page-for-binary mesos-agent mesos.x86_64: W: no-manual-page-for-binary mesos-daemon.sh mesos.x86_64: W: no-manual-page-for-binary mesos-master mesos.x86_64: W: no-manual-page-for-binary mesos-slave mesos.x86_64: W: no-manual-page-for-binary mesos-start-agents.sh mesos.x86_64: W: no-manual-page-for-binary mesos-start-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-start-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-start-slaves.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-agents.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-slaves.sh python2-mesos.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/mesos/cli.py 644 /usr/bin/python2 -s python2-mesos.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/mesos/futures.py 644 /usr/bin/python2 -s python2-mesos.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/mesos/http.py 644 /usr/bin/python2 -s 7 packages and 0 specfiles checked; 24 errors, 70 warnings. > mesos.src: W: strange-permission mesos-init-wrapper 775 This should be 755. > mesos.x86_64: W: incoherent-version-in-changelog 1.8.1 ['1.8.1-1.fc30', '1.8.1-1'] As described above: > mesos.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libmesos-1.8.1.so SSL_CTX_set_cipher_list Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/#_cc_applications mesos.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/libmesos-1.8.1.so mesos.x86_64: E: wrong-script-interpreter /etc/mesos/mesos-deploy-env.sh.template /usr/bin/env bash mesos.x86_64: E: non-executable-script /etc/mesos/mesos-deploy-env.sh.template 644 /usr/bin/env bash > mesos.x86_64: W: tmpfiles-conf-in-etc /etc/tmpfiles.d/mesos.conf As described above, move to %{_tpmfilesdir}. > mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.deps > mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.deps > mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.deps/.dirstamp > mesos.x86_64: E: zero-length /usr/share/mesos/examples/.deps/.dirstamp > mesos.x86_64: W: hidden-file-or-dir /usr/share/mesos/examples/.dirstamp > mesos.x86_64: E: zero-length /usr/share/mesos/examples/.dirstamp Remove. > mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/balloon_executor.cpp > mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/inverse_offer_framework.cpp > mesos.x86_64: E: wrong-script-interpreter /usr/share/mesos/examples/java/test-exception-framework.in /usr/bin/env bash > mesos.x86_64: E: non-executable-script /usr/share/mesos/examples/java/test-exception-framework.in 644 /usr/bin/env bash > mesos.x86_64: W: devel-file-in-non-devel-package /usr/share/mesos/examples/utils.hpp > [...] I would move all the examples in the devel subpackage, I don't think for a production cluster you need to have source code examples on each and every node. > mesos.x86_64: W: non-standard-uid /var/lib/mesos mesos > mesos.x86_64: W: non-standard-gid /var/log/mesos mesos This is fine. > mesos.x86_64: W: log-files-without-logrotate ['/var/log/mesos'] Correct, a simple logrotate file should be added. > mesos.x86_64: W: no-manual-page-for-binary mesos > [...] This is fine. > python2-mesos.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/mesos/cli.py 644 /usr/bin/python2 -s > python2-mesos.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/mesos/futures.py 644 /usr/bin/python2 -s > python2-mesos.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/mesos/http.py 644 /usr/bin/python2 -s I guess this should be 755, but probably can also be ignored as it is executed anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
