https://bugzilla.redhat.com/show_bug.cgi?id=1326504 --- Comment #20 from Jun Aruga <jaruga@xxxxxxxxxx> --- Hi Dave, Here is the updated spec file and srpm file after your reviewing. Spec URL: https://raw.githubusercontent.com/junaruga/htslib-pkg/hotfix/review/htslib.spec SRPM URL: https://github.com/junaruga/htslib-pkg/blob/hotfix/review/htslib-1.9-1.fc32.src.rpm?raw=true Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=37675570 A test to install binary RPMs: ok A test for rpmlint. There is below warning. But I like to postpone to fix it. ``` htslib.x86_64: W: shared-lib-calls-exit /usr/lib64/libhts.so.1.9 exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the- error, reporting it to the user, closing files properly, and cleaning up any- state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the- situation. ``` Below is the response for your review. > * licensecheck says Expat rather than MIT -- I haven't checked There is no "Expat" in the short name list used as "License:"'s value. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses Also below package setting "MIT" is actually detected as "Expat" by licensecheck command. https://src.fedoraproject.org/rpms/golang-uber-zap/blob/master/f/golang-uber-zap.spec#_33 I think "MIT" is fine. > * You could use %make_build in %build done. > * Remove the obsolete rm -rf from %install done > * To support EPEL, use %ldconfig_scriptlets instead of %post... done. I found a good example for that. https://src.fedoraproject.org/rpms/libmodulemd/c/75a7af962341becaa6a7076e0b1e68c874acc7f9 > * The library needs sorting out. Its soname is libhts.so.2, but it's installed as libhts.so.1.9 with a symlink to libhts.so.2. I haven't checked what's going on. The %files entry for it should be libhts.so.2*, so you know if it changes. If the version is actually taken from the release version -- I dont know -- it shouldn't be, and could be set to 0 for Fedora. I checked the upstream's behavior. ``` $ git clone git@xxxxxxxxxx:samtools/htslib.git $ cd htslib $ git checkout 1.9 $ make $ make install prefix=$(pwd)/dist ``` `make` command creates libhts.so (actual so file) and libhts.so.2 (symbolic link to libhts.so) on the current directory. But `make install prefix=$(pwd)/dist` creates below files soname: libhts.so.1.9 and symbolic links: libhts.so and libhts.so.2. libhts.so.1.9 is the actual soname used in the binary RPM file. ``` $ ls -l dist/lib/ total 10576 -rw-r--r-- 1 jaruga jaruga 7165054 Sep 15 21:54 libhts.a lrwxrwxrwx 1 jaruga jaruga 13 Sep 15 22:01 libhts.so -> libhts.so.1.9 -rw-r--r-- 1 jaruga jaruga 3653800 Sep 15 21:55 libhts.so.1.9 lrwxrwxrwx 1 jaruga jaruga 13 Sep 15 22:01 libhts.so.2 -> libhts.so.1.9 drwxr-xr-x 2 jaruga jaruga 4096 Sep 15 22:01 pkgconfig/ ``` Do you have any concerns about this situation? I suppose that current situation is no problem. And as an additional change, as Makefile "install" task includes "install-so" task, I removed "make "install-so" command line in htslib.spec. "make install" is good enough. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
