https://bugzilla.redhat.com/show_bug.cgi?id=1751138 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@xxxxxxxx --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- Some general hints: Drop this line: - %global commit v%{version} Simplify those lines: - URL: https://github.com/DNS-OARC/flamethrower - Source0: https://github.com/DNS-OARC/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz + URL: https://github.com/DNS-OARC/%{name} + Source0: %{url}/archive/v%{version}/%{name}-v%{version}.tar.gz - Patch1: flamethrower-0.10-libuv.patch + Patch1: %{name}-0.10-libuv.patch - make %{?_smp_mflags} + %make_build Why does %make_install not work though cmake is used to generate a useful Makefile? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
