[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1709037

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Missing: BR: gcc

Something's off with the spacing in description:
$ rpm -qp --qf '%{description}'
/var/lib/mock/fedora-rawhide-x86_64/result/python3-javabridge-1.0.18-2.20190723git16d6c91.fc32.x86_64.rpm|nl
-ba
     1  
     2  The javabridge Python package makes it easy to start a Java virtual
machine (JVM)
     3  from Python and interact with it. Python code can interact with the JVM
using a
     4  low-level API or a more convenient high-level API.

Also, having a description for the binary package which does not get created is
strange.

My suggestion:

%global _description %{expand:
The javabridge Python package makes it easy to start a Java virtual machine
(JVM)
from Python and interact with it. Python code can interact with the JVM using a
low-level API or a more convenient high-level API.}

%description %_description

%description -n python%{python3_pkgversion}-%{modname} %_description

>From %check:
> nose.plugins.cover: ERROR: Coverage not available: unable to import coverage module
→ maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning?

> sh: python: command not found
> Warning: Error loading ����
It seems unversioned python is being called.
The call is:
> /bin/sh bin/python -c import sysconfig; from os.path import join; print(join(sysconfig.get_config_var('LIBDIR'), sysconfig.get_config_var('multiarchsubdir')[1:], sysconfig.get_config_var('LDLIBRARY')))
This is going to give wrong results. I think that file needs to be patched to
call
%__python3 instead.

You build twice... I see setup.py manipulates sys.path to do import from $PWD,
which
doesn't work, because the binary module is missing. Too bad, I don't see an
easy way
to avoid this issue. Building twice doesn't seem so bad... OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux