https://bugzilla.redhat.com/show_bug.cgi?id=1751216 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #4 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Recommends: abattis-cantarell-fonts >... ># Change default font to Cantarell or DejaVu otherwise it won't run >sed -i 's!# font: OpenSans-Regular/10!font: %{_datadir}/fonts/cantarell/Cantarell-Regular.otf/11!' default.conf Fedora ships OpenSans (open-sans-fonts), why change this? Also, if "otherwise it won't run", then the font package should go in Requires:, not Recommends:. ># "Error generating new entries"" for key "Exec" in group "Desktop Entry" contains a reserved character '$' outside of a quote ># error: required key "Type" in group "Desktop Entry" is not present ># https://github.com/Tomas-M/xlunch/issues/109 >#desktop-file-validate %%{buildroot}%%{_datadir}/applications/genentries.desktop I looked at the .desktop file and I think the best way to solve this would be to extract the whole chain of commands into a helper shell script, and then just launch that script from the .desktop file. Also, taking a look at the upstream Makefile - the files are installed using "cp". Please consider patching this (and possibly sending the patch upstream) to use "cp -p" so that file timestamps are preserved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
