https://bugzilla.redhat.com/show_bug.cgi?id=1749751 --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- 1. Review * license okay - MIT for all files * spec file * mock build okay https://koji.fedoraproject.org/koji/taskinfo?taskID=37637054 * rpmlint okay for src.rpm, binary rpm, installed rpm * installable for F-32 * basic functionality okay (as documentated on "Usage" of https://github.com/kramdown/parser-gfm) ``` [mockbuild@1a996dddfd3e4efb85d341420b9e76a2 ~]$ ruby -e 'require "kramdown" ; require "kramdown-parser-gfm" ; text="This ~~is a complex strike through *test ~~with nesting~~ involved* here~~." ; puts Kramdown::Document.new(text, input: "GFM").to_html' <p>This <del>is a complex strike through *test ~~with nesting</del> involved* here~~.</p> ``` 2. Advice * BR - I would recommend to write "BuildRequires: rubygem(kramdown) >= 2.0" because on F-31 and below rubygem-kramdown is still 1.7.x and this srpm is incompatible on those branches (not a blocker for review) By the way do you plan to import this also on F-31? If so I will coordinate it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
