https://bugzilla.redhat.com/show_bug.cgi?id=1750983 --- Comment #2 from Filipe Brandenburger <filbranden@xxxxxxxxx> --- Hi Igor! Thanks for taking this review! I prepared a new spec file and build based on your comments: Spec URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/fedora-rawhide-x86_64/01031955-oomd/oomd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/srpm-builds/01031955/oomd-0.2.0-2.fc30.src.rpm > > Summary: Userspace Out-Of-Memory (OOM) killer for linux systems. > > Please remove '.' at the end of the line. Done. Also removed "for linux systems", simply "Userspace Out-Of-Memory (OOM) killer" is enough here. > > License: GPLv2 > > Can you clarify that it is not GPLv2+? That's correct, it's GPLv2 only, not GPLv2 or later. (See https://github.com/facebookincubator/oomd#license) > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz Ah nice! I was looking for so long for the GitHub URL that gives me a tarball including the package name and for the life of me couldn't find it... Thanks a bunch for that! > > BuildRequires: meson >= 0.45 > > Just BuildRequires: meson (if 0.45+ is needed, specify it in upstream too). I just checked and while Meson 0.44 works, it displays a warning ("WARNING: Passed invalid keyword argument 'main' in meson.build line 144.") due to issue https://github.com/mesonbuild/meson/issues/2828 Meson 0.43 doesn't work at all ("Value 'c++17' for combo option 'cpp_std' is not one of the choices.") Since there's a warning, I'd prefer to keep the dependency on 0.45 and not 0.44 (do you agree?) I'm happy to push a PR to document that upstream. That would be here (https://github.com/facebookincubator/oomd#building-and-installing), right? Thanks! Filipe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
