https://bugzilla.redhat.com/show_bug.cgi?id=1750263 --- Comment #2 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- Thank you Elliott for taking the review! (In reply to Elliott Sales de Andrade from comment #1) > - %global sum() is a bit weird; it's not a function. Fixed. > - Any reason not to use the PyPI archive? The tarball is usually different, smaller. E.g. LICENSE file is missing. But I fixed this, and reported: https://github.com/Alexis-benoist/eralchemy/pull/64 > - %python3_sitelib/* is no longer allowed by the Guidelines. You must specify > the subdirectories or files you want to include. Thanks for the info! Fixed. > - %{_bindir}/eralchemy should go in eralchemy package (which should depend on > the python3-elalchemy subpackage) Ok. Fixed. > - Are there no tests that could be run in %check? No, at least not with the PyPI tarball. Spec URL: https://raw.githubusercontent.com/praiskup/rpm-eralchemy/643cf131fd101dfa8d455a2a9197982e634eeab4/eralchemy.spec SRPM URL: http://praiskup.fedorapeople.org/eralchemy-1.2.10-1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
