https://bugzilla.redhat.com/show_bug.cgi?id=1750501 --- Comment #6 from J. Scheurich <mufti11@xxxxxx> --- This is a informal review, i am not in the packager group 8-( Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/fastbit See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "Expat License", "GPL (v2 or later)", "GPL (v3 or later)", "FSF Unlimited License (with Retention) GPL (v2 or later)", "FSF Unlimited License (with Retention)", "GNU Lesser General Public License". 254 files have unknown license. Detailed output of licensecheck in /home/mufti/review-fastbit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/java [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fastbit [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: fastbit-2.0.3-13.fc31.x86_64.rpm fastbit-devel-2.0.3-13.fc31.x86_64.rpm fastbit-java-2.0.3-13.fc31.x86_64.rpm fastbit-debuginfo-2.0.3-13.fc31.x86_64.rpm fastbit-debugsource-2.0.3-13.fc31.x86_64.rpm fastbit-2.0.3-13.fc31.src.rpm fastbit.x86_64: W: shared-lib-calls-exit /usr/lib64/libfastbit.so.1.0.0 exit@GLIBC_2.2.5 fastbit.x86_64: W: no-manual-page-for-binary ardea fastbit.x86_64: W: no-manual-page-for-binary fbmerge fastbit.x86_64: W: no-manual-page-for-binary ibis fastbit.x86_64: W: no-manual-page-for-binary rara fastbit.x86_64: W: no-manual-page-for-binary tcapi fastbit.x86_64: W: no-manual-page-for-binary thula fastbit.x86_64: W: no-manual-page-for-binary tiapi fastbit-devel.x86_64: W: no-documentation fastbit-devel.x86_64: W: no-manual-page-for-binary fastbit-config fastbit-java.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: fastbit-debuginfo-2.0.3-13.fc31.x86_64.rpm fastbit-java-debuginfo-2.0.3-13.fc31.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). fastbit.x86_64: W: invalid-url URL: https://sdm.lbl.gov/fastbit/ <urlopen error [Errno -2] Name or service not known> fastbit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfastbit.so.1.0.0 /lib64/librt.so.1 fastbit.x86_64: W: shared-lib-calls-exit /usr/lib64/libfastbit.so.1.0.0 exit@GLIBC_2.2.5 fastbit.x86_64: W: no-manual-page-for-binary ardea fastbit.x86_64: W: no-manual-page-for-binary fbmerge fastbit.x86_64: W: no-manual-page-for-binary ibis fastbit.x86_64: W: no-manual-page-for-binary rara fastbit.x86_64: W: no-manual-page-for-binary tcapi fastbit.x86_64: W: no-manual-page-for-binary thula fastbit.x86_64: W: no-manual-page-for-binary tiapi fastbit-devel.x86_64: W: invalid-url URL: https://sdm.lbl.gov/fastbit/ <urlopen error [Errno -2] Name or service not known> fastbit-devel.x86_64: W: no-documentation fastbit-devel.x86_64: W: no-manual-page-for-binary fastbit-config fastbit-debugsource.x86_64: W: invalid-url URL: https://sdm.lbl.gov/fastbit/ <urlopen error [Errno -2] Name or service not known> fastbit-debuginfo.x86_64: W: invalid-url URL: https://sdm.lbl.gov/fastbit/ <urlopen error [Errno -2] Name or service not known> fastbit-java.x86_64: W: invalid-url URL: https://sdm.lbl.gov/fastbit/ <urlopen error [Errno -2] Name or service not known> fastbit-java.x86_64: W: no-documentation fastbit-java-debuginfo.x86_64: W: invalid-url URL: https://sdm.lbl.gov/fastbit/ <urlopen error [Errno -2] Name or service not known> 6 packages and 0 specfiles checked; 0 errors, 18 warnings. Unversioned so-files -------------------- fastbit-java: /usr/lib64/fastbit/libfastbitjni.so Source checksums ---------------- https://code.lbl.gov/frs/download.php/file/426/fastbit-2.0.3.tar.gz : CHECKSUM(SHA256) this package : 1ddb16d33d869894f8d8cd745cd3198974aabebca68fa2b83eb44d22339466ec CHECKSUM(SHA256) upstream package : 1ddb16d33d869894f8d8cd745cd3198974aabebca68fa2b83eb44d22339466ec Requires -------- fastbit (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfastbit.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) fastbit-devel (rpmlib, GLIBC filtered): /usr/bin/sh fastbit(x86-64) libfastbit.so.1()(64bit) fastbit-java (rpmlib, GLIBC filtered): fastbit(x86-64) libc.so.6()(64bit) libfastbit.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) fastbit-debuginfo (rpmlib, GLIBC filtered): fastbit-debugsource (rpmlib, GLIBC filtered): Provides -------- fastbit: fastbit fastbit(x86-64) libfastbit.so.1()(64bit) fastbit-devel: fastbit-devel fastbit-devel(x86-64) fastbit-java: fastbit-java fastbit-java(x86-64) libfastbitjni.so()(64bit) fastbit-debuginfo: debuginfo(build-id) fastbit-debuginfo fastbit-debuginfo(x86-64) fastbit-debugsource: fastbit-debugsource fastbit-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/mufti/fastbit.spec 2019-09-10 01:22:58.936258286 -0400 +++ /home/mufti/review-fastbit/srpm-unpacked/fastbit.spec 2019-09-06 11:21:51.000000000 -0400 @@ -1,357 +1,178 @@ Name: fastbit - Version: 2.0.3 - Release: 13%{?dist} - Summary: An Efficient Compressed Bitmap Index Technology - # Main package is BSD; the Bison-generated parsers are GPLv3+ with exceptions; - # contribs/fbmerge is GPLv2+ - License: BSD and GPLv3+ with exceptions and GPLv2+ - URL: https://sdm.lbl.gov/fastbit/ - Source0: https://code.lbl.gov/frs/download.php/file/426/%{name}-%{version}.tar.gz - - - + # Code patch to fix format truncation issue, sent to upstream ML - Patch0: fastbit_format_truncation.patch - - - + # Code patch to fix FSF address in fbmerge.cpp, sent to upstream ML - Patch1: fastbit_fsf_address.patch - - - + # Code patch to remove indentation warnings, sent to upstream ML - Patch2: fastbit_indentation.patch - - - + # Code patch to remove unused variable warnings, sent to upstream ML - Patch3: fastbit_unused_variable.patch - - - + # Build system patch to ensure linkage to pthread - Patch10: fastbit_pthread_linkage.patch - - - + # Build system patch for tests to use compiled binaries, not libtool wrappers - Patch11: fastbit_tests_use_binaries.patch - - - + # Build system patch to avoid versioning the JNI shared library (plugin) - Patch12: fastbit_jni_avoid_version.patch - - - + # Fedora patch for java bindings to use System.load not System.loadLibrary - Patch20: fastbit_java_system_load.patch - - - + BuildRequires: autoconf - BuildRequires: automake - BuildRequires: gcc-c++ - BuildRequires: java-devel - BuildRequires: javapackages-tools - BuildRequires: perl-interpreter - - - + %description - FastBit is an open-source data processing library following the spirit of NoSQL - movement. It offers a set of searching functions supported by compressed bitmap - indexes. It treats user data in the column-oriented manner similar to - well-known database management systems such as Sybase IQ, MonetDB, and Vertica. - It is designed to accelerate user's data selection tasks without imposing undue - requirements. - - - + %package devel - Summary: FastBit development - Requires: %{name}%{?_isa} = %{version}-%{release} - %description devel - Development package for FastBit. Includes headers, libraries and man pages for - using FastBit API. - - - + %package java - Summary: FastBit Java libraries - Requires: %{name}%{?_isa} = %{version}-%{release} - %description java - FastBit API bindings for java using JNI. - - - + %prep - %autosetup -p1 -n %{name}-%{version} - - - + # remove bundled jars before build as required - rm -f java/tests/lib/commons-logging.jar - rm -f java/tests/lib/log4j-1.2.15.jar - rm -f java/tests/lib/junit-4.4.jar - - - + echo fixing permissions ... - find . -type f -perm /0111 \ - \( -name \*.cpp -or -name \*.h -or -name \*.yy -or -name \*.ll -or \ - -name \*.html -or -name README \) -print -exec chmod 0644 {} \; - - - + %build - aclocal -I tests/m4 - autoconf - automake --copy --no-force - %configure \ - --disable-static \ - --enable-contrib \ - --with-quiet-nan \ - --with-java=%{java_home} - # patch libtool to remove rpaths - sed -i 's|^hardcode_into_libs=.*|hardcode_into_libs=no|g' libtool - sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool - sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool - %make_build - - - + %check - # The test binaries need LD_LIBRARY_PATH to find the compiled fastbit library - # in the build tree. - %make_build LD_LIBRARY_PATH="%{buildroot}%{_libdir};%{_libdir}" check - - - + %install - %make_install - - - + # move jar file to _jnidir, as required - install -d -m 0755 %{buildroot}%{_jnidir} - mv %{buildroot}%{_libdir}/fastbitjni.jar %{buildroot}%{_jnidir}/%{name}.jar - chmod 0644 %{buildroot}%{_jnidir}/%{name}.jar - - - + # move JNI shared library to _libdir/name, as required - install -d -m 0755 %{buildroot}%{_libdir}/%{name} - mv %{buildroot}%{_libdir}/libfastbitjni.so %{buildroot}%{_libdir}/%{name}/ - - - + # remove libtool archives - find %{buildroot} -name \*.la | xargs rm -f - - - + %ldconfig_scriptlets - %ldconfig_scriptlets -n devel - - - + %files - %doc NEWS README - %license COPYING - %{_docdir}/%{name}/*.html - %{_bindir}/ardea - %{_bindir}/fbmerge - %{_bindir}/ibis - %{_bindir}/rara - %{_bindir}/tcapi - %{_bindir}/thula - %{_bindir}/tiapi - %{_libdir}/libfastbit.so.* - - - + %files devel - %dir %{_prefix}/include/%{name} - %{_prefix}/include/%{name}/*.{h,hh} - %{_bindir}/fastbit-config - %{_libdir}/libfastbit.so - - - + %files java - %dir %{_libdir}/%{name} - %{_libdir}/%{name}/libfastbitjni.so - %{_jnidir}/%{name}.jar - - - + %changelog - * Fri Sep 6 2019 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-13 - - Remove unnecessary build dependencies - - Improve packaging conformance - - - + * Wed Jun 19 2019 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-12 - - Use make_build macro instead of make - - - + * Wed Jun 19 2019 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-11 - - Replace __make macro with make - - - + * Wed Jun 19 2019 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-10 - - Stop using autotools macros that were removed from rpm - - - + * Thu Jan 31 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 2.0.3-9 - - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild - - - + * Fri Jul 13 2018 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 2.0.3-8 - - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild - - - + * Fri May 25 2018 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-7 - - Add BuildRequires javapackages-tools for needed rpm macros - - - + * Wed Mar 07 2018 Adam Williamson <awilliam@xxxxxxxxxx> - 2.0.3-6 - - Rebuild to fix GCC 8 mis-compilation - See https://da.gd/YJVwk ("GCC 8 ABI change on x86_64") - - - + * Sat Feb 10 2018 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-5 - - Use new ldconfig_scriptlets macro. - - - + * Wed Feb 07 2018 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 2.0.3-4 - - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild - - - + * Tue Jan 23 2018 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-3 - - Ensure linkage to pthread (for ld flag -z defs). - - - + * Wed Dec 20 2017 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-2 - - Fix minor typos in spec. - - - + * Tue Oct 10 2017 Philip Kovacs <pkdevel@xxxxxxxxx> - 2.0.3-1 - - Packaging for Fedora. - - \ No newline at end of file Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -n fastbit Buildroot used: fedora-rawhide-x86_64 Active plugins: Java, Generic, Shell-api, C/C++ Disabled plugins: Ocaml, fonts, SugarActivity, Python, Haskell, R, Perl, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
