https://bugzilla.redhat.com/show_bug.cgi?id=1741805 Lukas Javorsky <ljavorsk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ljavorsk@xxxxxxxxxx --- Comment #6 from Lukas Javorsky <ljavorsk@xxxxxxxxxx> --- Hi, I've tried to build it in container and test the functionality, but I don't think it works right. Example: lolcat /dev/urandom # It doesn't print anything Tried it with cat first: cat /dev/urandom > foo # Stop it manually (^C) lolcat foo # Still nothing And a few things that I've noticed in spec: - Use macros everywhere you can - Source, URL: change the lolcat to %{name} - This is not a mistake, but I think that your Changelog doesn't need that many releases, try to make them useful, IMHO your package would be great only with the "Initial package" one, but it's totally up to you how you make it. Not diving into deep review, I will wait until your review on the functionality of the program -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
