https://bugzilla.redhat.com/show_bug.cgi?id=1750047 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vitaly@xxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |vitaly@xxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #4 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- I will review this package. 1. Fix shebang, because /usr/bin/env is not allowed. 2. Remove duplicate dependency Requires: python3. 3. Use boolean dependecies: "Suggests:gnome-shell-extension-appindicator" -> "Recommends: gnome-shell-extension-appindicator if gnome-shell" or "Supplements: gnome-shell". 4. Add symbolic links offload-glx and offload-vulkan to main script mate-optimus-applet. 5. "Recommends: akmod-nvidia >= 435.17" -> "Recommends: xorg-x11-drv-nvidia >= 435.17". 6. Fix path to launcher in %description. 7. Add "Requires: libnotify". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
