https://bugzilla.redhat.com/show_bug.cgi?id=1749094 --- Comment #6 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- - Add a comment explaining the License breakdown. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios - Add a comment explaining the reason for the patch (and upstream status if applicable.) https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment - Don't gzip man pages manually; that'll be done for you. Also, list it as %{name}.1* https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages - Also, preserve timestamps when copying the manpage (cp -p or install -p): https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps - %dir %{_datadir}/zsh/ and %dir %{_datadir}/zsh/site-functions must be owned by this package; they are not owned by filesystem. - You seem to have dropped %dir %{_datadir}/doc/%{name} which still needs to be owned. - The sources in the upstream tarball and the one used to make the srpm do not match; why is that? Also, I meant to ask before; there seems to be a tests directory, but they aren't run in %check. Can this not be added? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in 1749094-polybar/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "BSD 2-clause "Simplified" License", "*No copyright* Expat License". 542 files have unknown license. Detailed output of licensecheck in 1749094-polybar/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/polybar [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/zsh, /usr/share/doc/polybar, /usr/share/zsh/site-functions [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in polybar [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: polybar-3.4.0-1.fc32.x86_64.rpm polybar-debuginfo-3.4.0-1.fc32.x86_64.rpm polybar-debugsource-3.4.0-1.fc32.x86_64.rpm polybar-3.4.0-1.fc32.src.rpm polybar.x86_64: W: no-manual-page-for-binary polybar-msg 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: polybar-debuginfo-3.4.0-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- polybar.x86_64: W: no-manual-page-for-binary polybar-msg 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://github.com/polybar/polybar/archive/3.4.0/polybar-3.4.0.tar.gz : CHECKSUM(SHA256) this package : 6cecfd875b3821321f2c88621ee76aaeec9a28224a6e2d87284388be219a0310 CHECKSUM(SHA256) upstream package : b8bd84b5154c4723181ec1ef74c0f278583fd80c81ca0aa9bcbce4c537f9ec45 diff -r also reports differences Requires -------- polybar (rpmlib, GLIBC filtered): libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcurl.so.4()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libiw.so.29()(64bit) libjsoncpp.so.21()(64bit) libm.so.6()(64bit) libmpdclient.so.2()(64bit) libmpdclient.so.2(libmpdclient2)(64bit) libpthread.so.0()(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxcb-composite.so.0()(64bit) libxcb-cursor.so.0()(64bit) libxcb-ewmh.so.2()(64bit) libxcb-icccm.so.4()(64bit) libxcb-randr.so.0()(64bit) libxcb-xkb.so.1()(64bit) libxcb-xrm.so.0()(64bit) libxcb.so.1()(64bit) rtld(GNU_HASH) polybar-debuginfo (rpmlib, GLIBC filtered): polybar-debugsource (rpmlib, GLIBC filtered): Provides -------- polybar: polybar polybar(x86-64) polybar-debuginfo: debuginfo(build-id) polybar-debuginfo polybar-debuginfo(x86-64) polybar-debugsource: polybar-debugsource polybar-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1749094 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: fonts, SugarActivity, Java, Haskell, Ocaml, Python, PHP, R, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
