https://bugzilla.redhat.com/show_bug.cgi?id=1747811 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaly@xxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |vitaly@xxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #7 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- I will review this package. 1. Ask upstream to add license files. 2. Python 2 is deprecated and must not be used in Rawhide. Please ask upstream to port scripts to Python 3 or do it manually and then send PR to upstream. 3. Patches should be applied in %prep. 4. Use sed -i 's!/bin/env python2!%{__python3}!' indicator-test-tool/ksni.py instead of hardcoding path. 5. I think it will be better to use /usr/bin/install with explicitly set chmod instead of just copying files to destination directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
