[Bug 1748059] Review Request: python-license-expression - Library to parse, compare, simplify and normalize license expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1748059



--- Comment #2 from Carmen Bianca Bakker <carmen@xxxxxxxxxxxxxxx> ---
> - You should delete PKG-INFO and src/license_expression.egg-info in %prep.

These files don't exist in the source tarball, and they aren't included
in the final RPM either. I'm not sure about this step.

> - Passing %{pypi_name} to %pypi_source is unnecessary.
> - `irc-notify.py` is GPLv2+, but not installed. Please add a note above the
>   License so others aren't confused by it.
> - `Requires: %{py3_dist boolean.py}` is unnecessary and redundant with
> automatic
>   Provides/Requires.

Done x3. Spec and SRPM updated. Thanks :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux