https://bugzilla.redhat.com/show_bug.cgi?id=1739816 --- Comment #6 from Ege Güneş <egegunes@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #5) > - That's not needed, the file should be in licensedir > > %{_docdir}/redminecli/LICENSE > The setup.py script tries to install license to `sys.prefix` (`/usr`) if include it in the dist. I couldn't see any macro that points to default licensedir. Can you point me the right direction? > - You haven't added the tests? Tests confused me because Python Packaging Docs[1] explicitly says "Python modules must not download any dependencies during the build process.". But I need to download the packages' dependencies to test it? Am I missing something? [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_reviewer_checklist -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
