https://bugzilla.redhat.com/show_bug.cgi?id=1745846 --- Comment #12 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- (In reply to Miro Hrončok from comment #10) > Package should install a .desktop file using desktop-file-install or run > desktop-file-validate. The .desktop file is specific to KDE Plasma as provided by KDE SIG themselves. > > Package must own all directories that it creates. > Directories without known owners: > /usr/share/wallpapers > /usr/share/gnome-background-properties > /usr/share/backgrounds/f31 > Weird. Something is not right on the fedora-review. The spec file clearly lists: %dir %{_datadir}/backgrounds/%{bgname} %dir %{_datadir}/gnome-background-properties/ which should set to the right owners. The ownership of "/usr/share/wallpapers" should be set to KDE using their macro %{_kde4_datadir}. It seems like a bug. > > License mismatch: The package installs Free-Art-1.3, but the files are under > Free-Art-1.0 (according to Attribution-Extras). > Fixed. > Diff spec file in url and in SRPM > --------------------------------- > --- > /home/churchyard/rpmbuild/FedoraReview/1745846-f31-backgrounds/srpm/f31- > backgrounds.spec 2019-08-28 06:28:18.636493744 +0200 > +++ > /home/churchyard/rpmbuild/FedoraReview/1745846-f31-backgrounds/srpm-unpacked/ > f31-backgrounds.spec 2019-08-27 15:08:09.000000000 +0200 > @@ -37,4 +37,5 @@ > %package base > Summary: Base images for Fedora %{relnum} default background > +License: CC-BY-SA > > %description base Fixed. SPECS: https://github.com/fedoradesign/backgrounds/releases/download/v31.0.2/f31-backgrounds.spec SRPMS: https://github.com/fedoradesign/backgrounds/releases/download/v31.0.2/f31-backgrounds-31.0.2-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
