https://bugzilla.redhat.com/show_bug.cgi?id=1740804 Severin Gehwolf <sgehwolf@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- Thanks for the review! (In reply to Jie Kang from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: sonatype-oss-parent is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ Now removed in %prep and filed an upstream issue which I've mentioned as a comment in spec. > - Note: No javadoc subpackage present. Note: Javadocs are optional for > Fedora versions >= 21 > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Yes, optional. I don't intend to build javadocs. > - Version in changelog is 0.6.0 but Version is 0.12.0 Fixed. > - Package contains bundled libraries, see rpmlint Provides section This is a Java agent package. Same reasoning applies for prometheus-jmx-exporter as for jolokia-jvm-agent. This package does proper name-spacing of bundled libs which is better. Bundled provides are present as per packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
