https://bugzilla.redhat.com/show_bug.cgi?id=1740786 --- Comment #3 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- Thanks for the review! (In reply to Jie Kang from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Note: No javadoc subpackage present. Note: Javadocs are optional for > Fedora versions >= 21 > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Yes. As they are optional I don't intend to add javadocs for this package. > - > jolokia-1.6.2/client/javascript/test-app/src/main/javascript/support/jquery. > flot.js > Has header text: * Released under the MIT license by IOLA, December 2007. > Does the SPEC need to list this? From https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_field: """ The License: field refers to the licenses of the contents of the binary rpm. When in doubt, ask. """ This is a test-only artifact and not part of the binary. Hence, we don't need to add it. > - Package contains bundled libraries, see rpmlint Provides section See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling """ Fedora packages SHOULD make every effort to avoid having multiple, separate, upstream projects bundled together in a single package. """ Since this is packaging a java agent the situation is somewhat similar to byteman and others. The prometheus jmx exporter is in a similar boat. In order for an agent to work well and not run into very strange class loading issues it's recommended for Java agents to a) keep the deps light b) rewrite the deps to a special namespace so no conflicts can arise. I.e. simple-json in this case should be shaded and bytecode-rewritten into the org.jolokia namespace (over just including it in the jar). I've linked an upstream issue for b) and have added the bundled() provides for that reason. That's the lesser of the evil in this case. The alternative would be to require simple json be specified on the classpath/modulepath. It would be a divergence from upstream and it is susceptible to run into class loading issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
