https://bugzilla.redhat.com/show_bug.cgi?id=1740795 --- Comment #3 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- Thanks for the review, Jie! (In reply to Jie Kang from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: sonatype-oss-parent is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ I've removed the dependency on sonatype-oss-parent and opened an upstream PR about it. See comment in spec. The dependency is only needed for deploying to maven repositories it seems (not needed for Fedora). > - Note: No javadoc subpackage present. Note: Javadocs are optional for > Fedora versions >= 21 Yes. Right now, I do not intend to build javadocs for this package. > - ./srpm-unpacked/client_java-parent-0.6.0/.mvn/wrapper/maven-wrapper.jar > Bundled jar/class files should be removed before build > Note: Jar files in source (see attachment) > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/Java/#_pre_built_dependencies Removed now in %prep. > - > srpm-unpacked/client_java-parent-0.6.0/simpleclient_spring_boot/src/test/ > java/io/prometheus/client/matchers/CustomMatchers.java > Is licensed under Creative Commons BY-SA 3.0. Does the SPEC need to list > this? It's not being built/used during build, FWIW. I've added CC-BY_SA as a license regardless. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
