[Bug 1744132] Review Request: grafana-pcp - Performance Co-Pilot App for Grafana

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1744132



--- Comment #2 from Andreas Gerstmayr <agerstmayr@xxxxxxxxxx> ---
Thanks for the review!

(In reply to Robert-André Mauchin from comment #1)
>  - This shouldn't be needed as it is a noarch package:
> 
> %global         _debugsource_template %{nil} # avoid empty
> debugsourcefiles.list

I removed this line now.

> 
>  - Please add a comment or include a script as Source which explains how
> grafana-pcp-deps-%{version}.tar.xz was generated.

Ok, I've updated the spec and the SRPM at the same location.

> grafana-pcp.noarch: E: world-writable
> /var/lib/grafana/plugins/grafana-pcp/components/config/config.html 666

Not sure what's wrong here, when I run
$ rpm -qp --dump ~/rpmbuild/RPMS/noarch/grafana-pcp-0.0.7-1.fc30.noarch.rpm |
grep config/config.html

it shows me

/var/lib/grafana/plugins/grafana-pcp/components/config/config.html 613
1566824688 6c8a49f249880ccbc8ebb19c9097a0944b58229cc0b71948011f419839deeca6
0100644 root root 0 0 0 X

> grafana-pcp.src: W: invalid-url Source1: grafana-pcp-deps-0.0.7.tar.xz

Anything I can / should do about that one?


Cheers,
Andreas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux