[Bug 1745368] New: Review Request: rubygem-sassc - Use libsass with Ruby!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1745368

            Bug ID: 1745368
           Summary: Review Request: rubygem-sassc - Use libsass with Ruby!
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody@xxxxxxxxxxxxxxxxx
          Reporter: decathorpe@xxxxxxxxx
        QA Contact: extras-qa@xxxxxxxxxxxxxxxxx
                CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx
  Target Milestone: ---
    Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/rubygem-sassc.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/rubygem-sassc-2.1.0-1.fc30.src.rpm

Description: Use libsass with Ruby!

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=37276397


Packager's notes:
-----------------

- I unbundled libsass from the package, and modified the ruby code to load
libsass from the fedora package.

- The package is *not* noarch on purpose, because the gem loads
%{_libdir}/libsass.so.1 at runtime via FFI.

- I disabled two tests that are slightly broken with the version of libsass in
fedora (3.5.5, which is a bit older than the one that's bundled in the sassc
gem - 3.6.1). One test checks for the version of the library (which fails
because 3.5.5 != 3.6.1), and the other one tests for floating point precision,
which seems to have changed between libsass versions.

This gem is a new dependency of jekyll 4.0.0+ (which I intend to update in
rawhide and f31) because upstream migrated from the deprecated sass gem to
sassc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux