https://bugzilla.redhat.com/show_bug.cgi?id=1739290 --- Comment #12 from Wart <wart@xxxxxxxxxx> --- (In reply to J. Scheurich from comment #11) > Shouldn't you create %{_datadir}/icons/hicolor/32x32/apps/ ? > > %files > ... > %dir %{_datadir}/icons/hicolor/32x32/apps/ > %{_datadir}/icons/hicolor/32x32/apps/%{name}.png This would be incorrect, as %{_datadir}/icons/hicolor/32x32/apps/ is already owned by the hicolor-icon-theme and fedora-logos packages (at least on Fedora 30). Per the packaging guidelines, I don't believe it's necessary to add an explicit dependency on hicolor-icon-theme or fedora-logos: "Directory ownership is a little more complex than file ownership. Packages must own all directories they put files in, except for: * any directories owned by the filesystem, man, or other explicitly created -filesystem packages * any directories owned by other packages in your package’s natural dependency chain" My interpretation is that 'hicolor-icon-theme' falls under the 'natural dependency chain' for graphical applications, as it is pulled in by two primary window managers: gnome-icon-theme and kde-libs. Thus, no explicit Requires: would be necessary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
