https://bugzilla.redhat.com/show_bug.cgi?id=1744429 Lubomir Rintel <lrintel@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lrintel@xxxxxxxxxx --- Comment #2 from Lubomir Rintel <lrintel@xxxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #1) > Pass -Dwerror=false; don't mess with sed. Ah, thanks for this. I didn't know you can pass compiler options here. > Please pass all with_* options explicitly. They are currently 'auto', which > means they could magically turn off without you knowing. No. With %meson they're enabled by default: $ rpm --eval %meson |sed 's/ /\n/g' |grep auto-features --auto-features=enabled > The Release tag should start at 1, not 0. Whoops. Fixed now. > > It's a bit weird to see %doc and %license after the other files, but not a > real > problem. Is it? I've always done that ways and now just randomly checked a couple of packages and they all have %doc and %license at the end. Thanks for the review! New package: SPEC: http://v3.sk/~lkundrak/SPECS/waypipe.spec SRPM: http://v3.sk/~lkundrak/SRPMS/waypipe-0.6.0-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
