https://bugzilla.redhat.com/show_bug.cgi?id=910340 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #12 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Timothy Mullican from comment #7) > Created attachment 1600561 [details] > Updated RPM spec file > > I have created an updated RPM spec file which should conform with best > practices. Could you open a new bug for it and mark this one as Duplicate? CC me on the bug. - Make Source0 as url %global commit 619d97fbeeb30cc5b7f58ecb9a020ca594deead5 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20190822 Source0: https://github.com/suleman1971/boinctui/archive/%{commit}/%{name}-%{shortcommit}.tar.gz […] %autosetup -n %{name}-%{commit} - Drop Source1. - Shouldn't be needed: Requires: ncurses Requires: expat Requires: openssl - make %{?_smp_mflags} is the same thing as %make_build %build autoreconf -vif %configure --without-gnutls %make_build - Don't mix $RPM_BUILD_ROOT and %{buildroot} %install %make_install mkdir -p %{buildroot}%{_mandir}/man1 install -m 0644 %{name}.1 %{buildroot}%{_mandir}/man1/ - Don't gzip the manpage, it is automated - Not needed: %clean rm -rf %{buildroot} - Don't use %attr(-, root, root) in %files Glob the extension of the manpage as the compression might change in the future: %files %doc changelog %license gpl-3.0.txt %{_bindir}/%{name} %{_mandir}/man1/%{name}.1.* - Separate your changelog entry by a newline -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
