[Bug 1739787] Review Request: python-decopatch - A helper to write python decorators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1739787

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Not familiar with Pyproject, shouldn't you also include the Python provide
macro?

%package -n python3-decopatch
Summary: %{summary}
%{?python_provide:%python_provide python3-decopatch}

%description -n python3-decopatch %_description


 - Build fails:

+ cd decopatch-1.4.5
+ CFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld'
+ /usr/bin/python3 -m pip wheel --no-deps --use-pep517 --no-build-isolation
--disable-pip-version-check --progress-bar off --verbose .
BUILDSTDERR:     Running command /usr/bin/python3
/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py
prepare_metadata_for_build_wheel /tmp/tmpq7dztlbs
BUILDSTDERR:     Traceback (most recent call last):
BUILDSTDERR:       File "setup.py", line 22, in <module>
BUILDSTDERR:         from setuptools_scm import get_version
BUILDSTDERR:     ModuleNotFoundError: No module named 'setuptools_scm'


Seems the %generate_buildrequires part is broken:

Executing(%generate_buildrequires): /bin/sh -e /var/tmp/rpm-tmp.LdbKYs
+ umask 022
+ cd /builddir/build/BUILD
+ cd decopatch-1.4.5
+ echo python3-devel
+ echo 'python3dist(packaging)'
+ echo 'python3dist(pip) >= 19'
+ echo 'python3dist(pytoml)'
+ rm -rfv '*.dist-info/'
+ '[' -f /usr/bin/python3 ']'
+ RPM_TOXENV=py38

The above packages are installed.

+ /usr/bin/python3 -I /usr/lib/rpm/redhat/pyproject_buildrequires.py
BUILDSTDERR: Handling pytest-runner from build-system.requires
BUILDSTDERR: Handling setuptools_scm from build-system.requires
BUILDSTDERR: Handling pypandoc from build-system.requires
BUILDSTDERR: Handling six from build-system.requires
BUILDSTDERR: Requirement satisfied: six
BUILDSTDERR:    (installed: six 1.12.0)
BUILDSTDERR: Exiting dependency generation pass: build backend
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ exit 0
python3-devel
python3dist(packaging)
python3dist(pip) >= 19
python3dist(pytoml)
python3dist(pytest-runner)
python3dist(setuptools-scm)
python3dist(pypandoc)
python3dist(six)

The ones detected above are not.

See scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=37225926

The current macros seems broken: in order to run pyproject_buildrequires.py,
you need packaging, pip and pytoml. They are included in the
%generate_buildrequires macro, but are installed after the call to
pyproject_buildrequires.py

%pyproject_buildrequires(rxte:) %{expand:\\\
%{-e:%{expand:%global toxenv %{-e*}}}
echo 'python3-devel'
echo 'python3dist(packaging)'
echo 'python3dist(pip) >= 19'
echo 'python3dist(pytoml)'
# setuptools assumes no pre-existing dist-info
rm -rfv *.dist-info/
if [ -f %{__python3} ]; then
  RPM_TOXENV="%{toxenv}" %{__python3} -I
%{_rpmconfigdir}/redhat/pyproject_buildrequires.py %{?**}
fi
}

Hence the pyproject_buildrequires.py script fails to run. It seems it only work
on a warm chroot with packaging, pip and pytoml already installed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux