Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asylum - SDL port of the game Asylum, originally for the Archimedes https://bugzilla.redhat.com/show_bug.cgi?id=291661 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxx 2007-10-03 03:22 EST ------- OK - Meets Packaging Guidelines. OK - Package named correctly OK - Patches named correctly OK - Spec file named correctly to match base OK - License is valid OK - Licence field matches package OK - Licence file installed if supplied OK - Spec file in American English OK - Source matches upstream (md5) e349a99bf099df818b0efc4f83359858 NA - Locales use %find_lang No locales OK - %clean is present and correct OK - Package has correct buildroot. OK - Specfile Legible OK - Builds in Mock F7-i386 NA - %post/%postun calls ldconfig for sh libs No sh libs OK - Owns directories it creates OK - No duplicate files OK - Has %defattr and has correct permissions ?? *2 Macros used consistently OK - %doc does not affect runtime NA - Headers/static libs in -devel NA - .pc files in -devel NA - .so files in -devel NA - -devel requires base No devel OK - Contains no .la libtool archive files OK - Does not own others files OK - .desktop files installed correctly OK - BuildRequires correct. OK - Package is code or permissible content. OK - Package has rm -rf %{buildroot} at top of %install. OK - Package compiles and builds on at least one arch. F7-i386 OK *1 rpmlint output. NA - documentation in -doc package OK - final provides and requires are sane. OK - should have dist tag OK - should package latest version Move %doc to top of %files to aid readability *1 asylum.i386: E: non-standard-executable-perm /usr/bin/asylum 02755 asylum.i386: E: non-standard-dir-perm /var/games/asylum 0775 Both due to global hi-score table as explained above. *2 Not a blocker but definitely a suggestion. Some path details are "hardcoded" into the Makefile and makefile patch. While the location of /usr/bin /usr/share/asylum and /var/games/asylum are not likely to change anytime soon it would be more visible to make these changes with sed in the specfile making use of the available macros. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review