https://bugzilla.redhat.com/show_bug.cgi?id=1739784 --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- 1) License tag need to be "LGPLv3+". Whenever license text says "or (at your option) any later version" use "+". 2) Package name should be python-pysimplesoap because we need to use the name that we import library. Here we will be using "import pysimplesoap" so package name is python-<modulename> that is python-pysimplesoap. 3) License text is not present and I can see upstream also have tests. In this case I generally recommends to use upstream tarball as a source URL but upstream has not released a new tarball so you can ask upstream to do so OR Source1: https://raw.githubusercontent.com/pysimplesoap/pysimplesoap/master/license.txt upload this file with upstream tarball and add in %prep cp -p %{SOURCE1} . then in %files section %doc license.txt 4) Instead of what has been packaged in above SRPM, change it to %prep %autosetup -n %{pypi_name}-%{version} for lib in pysimplesoap/*.py; do sed -e '1{\@^#! /usr/bin/env python@d}' -e '1{\@^#!/usr/bin/env python@d}' \ -e '1{\@^#!/usr/bin/python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done %build %py3_build %install %py3_install Update the spec and submit new update for further review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
